Skip to content

chore: Ensure correct deploy order#1800

Closed
metal-messiah wants to merge 31 commits into
mainfrom
fix-ci-issues
Closed

chore: Ensure correct deploy order#1800
metal-messiah wants to merge 31 commits into
mainfrom
fix-ci-issues

Conversation

@metal-messiah

Copy link
Copy Markdown
Member

ensure we are compliant with company deploy order -- https://newrelic.slack.com/archives/C08235DFQU9/p1780410802570979

Overview

Related Issue(s)

Testing

@github-actions

Copy link
Copy Markdown

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.94 kB / 10.27 kB (gzip) 26.86 kB / 10.26 kB (gzip) -0.33% / -0.1% (gzip)
lite async-chunk 59.66 kB / 20.07 kB (gzip) 59.62 kB / 20.05 kB (gzip) -0.07% / -0.06% (gzip)
pro loader 69.21 kB / 24.32 kB (gzip) 70.33 kB / 24.7 kB (gzip) 1.62% / 1.57% (gzip)
pro async-chunk 97.22 kB / 30.83 kB (gzip) 97.17 kB / 30.83 kB (gzip) -0.05% / -0.03% (gzip)
spa loader 71.61 kB / 25.08 kB (gzip) 72.73 kB / 25.46 kB (gzip) 1.57% / 1.49% (gzip)
spa async-chunk 109.36 kB / 34.03 kB (gzip) 109.32 kB / 34.02 kB (gzip) -0.04% / -0.02% (gzip)

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (d75f4bf) to head (3839354).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   90.09%   90.12%   +0.03%     
==========================================
  Files         214      215       +1     
  Lines        7852     7972     +120     
  Branches     1669     1706      +37     
==========================================
+ Hits         7074     7185     +111     
- Misses        708      716       +8     
- Partials       70       71       +1     
Flag Coverage Δ
unit-tests 86.19% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/workflows/internal-promotion.yml Outdated
Comment thread .github/workflows/deploy-environment.yml Outdated
*) AWS_ROLE="${{ secrets.INTERNAL_PRODUCTION_APPLICATION_ID }}" ;;
esac
echo "aws_role=${AWS_ROLE}" >> $GITHUB_OUTPUT
echo "nrba_app_id=${AWS_ROLE}" >> $GITHUB_OUTPUT

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • AWS_ROLE is being assigned app id
  • Also, should these replace the previous inline assignments on lines 151 and 198 (for entity guids).

--stage-api-key=$STAGE_API_KEY \
--local-dir=./build
node .github/actions/nr-verify/index.js \
--local-dir=./build

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--local-dir=./build
--environment=stage \
--local-dir=./build

@metal-messiah

Copy link
Copy Markdown
Member Author

closed in favor of #1802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants