chore: Ensure correct deploy order#1800
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
+ Coverage 90.09% 90.12% +0.03%
==========================================
Files 214 215 +1
Lines 7852 7972 +120
Branches 1669 1706 +37
==========================================
+ Hits 7074 7185 +111
- Misses 708 716 +8
- Partials 70 71 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| *) AWS_ROLE="${{ secrets.INTERNAL_PRODUCTION_APPLICATION_ID }}" ;; | ||
| esac | ||
| echo "aws_role=${AWS_ROLE}" >> $GITHUB_OUTPUT | ||
| echo "nrba_app_id=${AWS_ROLE}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
- AWS_ROLE is being assigned app id
- Also, should these replace the previous inline assignments on lines 151 and 198 (for entity guids).
| --stage-api-key=$STAGE_API_KEY \ | ||
| --local-dir=./build | ||
| node .github/actions/nr-verify/index.js \ | ||
| --local-dir=./build |
There was a problem hiding this comment.
| --local-dir=./build | |
| --environment=stage \ | |
| --local-dir=./build |
|
closed in favor of #1802 |
ensure we are compliant with company deploy order -- https://newrelic.slack.com/archives/C08235DFQU9/p1780410802570979
Overview
Related Issue(s)
Testing