Skip to content

feat: Add websocket init config#1803

Merged
ellisong merged 2 commits into
mainfrom
NR-553178-websocket-config
Jul 6, 2026
Merged

feat: Add websocket init config#1803
ellisong merged 2 commits into
mainfrom
NR-553178-websocket-config

Conversation

@ellisong

Copy link
Copy Markdown
Contributor

Adds web_sockets block to NREUM init configuration. Setting web_sockets.enabled to true turns on the web sockets feature. The web sockets feature is disabled by default.

Overview

Adds web_sockets configuration in the init block to turn on the web sockets feature. It can also be turned on through the websockets feature flag.

Related Issue(s)

JIRA: https://new-relic.atlassian.net/browse/NR-553178

Testing

Make sure tests pass, especially the library tests.

@ellisong ellisong temporarily deployed to nr1-experiments June 29, 2026 22:31 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.94 kB / 10.27 kB (gzip) 26.88 kB / 10.27 kB (gzip) -0.23% / 0.01% (gzip)
lite async-chunk 59.66 kB / 20.07 kB (gzip) 59.62 kB / 20.05 kB (gzip) -0.07% / -0.06% (gzip)
pro loader 69.28 kB / 24.34 kB (gzip) 70.39 kB / 24.72 kB (gzip) 1.6% / 1.53% (gzip)
pro async-chunk 97.22 kB / 30.83 kB (gzip) 97.2 kB / 30.84 kB (gzip) -0.01% / 0.04% (gzip)
spa loader 71.68 kB / 25.1 kB (gzip) 72.78 kB / 25.48 kB (gzip) 1.55% / 1.51% (gzip)
spa async-chunk 109.36 kB / 34.03 kB (gzip) 109.35 kB / 34.03 kB (gzip) -0.01% / 0.02% (gzip)

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (d75f4bf) to head (8b6e489).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
+ Coverage   90.09%   90.12%   +0.03%     
==========================================
  Files         214      215       +1     
  Lines        7852     7972     +120     
  Branches     1669     1707      +38     
==========================================
+ Hits         7074     7185     +111     
- Misses        708      716       +8     
- Partials       70       71       +1     
Flag Coverage Δ
unit-tests 86.19% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ellisong ellisong temporarily deployed to nr1-experiments June 29, 2026 22:34 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

Static Badge

Last ran on June 30, 2026 14:31:59 CDT
Checking merge of (05ca1e0) into main (eed67ae)

@metal-messiah

metal-messiah commented Jun 30, 2026

Copy link
Copy Markdown
Member

Can you also update the flag/init for

  • publish-experiment.yml
  • internal-promotion > released.js <-- I think we should be ok to expose this to NR1 at this point

@metal-messiah metal-messiah self-assigned this Jun 30, 2026
@ellisong ellisong force-pushed the NR-553178-websocket-config branch from 05ca1e0 to 8b6e489 Compare June 30, 2026 21:18
@ellisong ellisong temporarily deployed to nr1-experiments June 30, 2026 21:19 — with GitHub Actions Inactive
@ellisong ellisong merged commit aa4d2f3 into main Jul 6, 2026
36 checks passed
@ellisong ellisong deleted the NR-553178-websocket-config branch July 6, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants