fix: Keep Ajax payload out of unrelated events#1809
Open
ptang-nr wants to merge 1 commit into
Open
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
+ Coverage 90.09% 90.23% +0.14%
==========================================
Files 214 215 +1
Lines 7852 7988 +136
Branches 1669 1704 +35
==========================================
+ Hits 7074 7208 +134
- Misses 708 710 +2
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops captured AJAX request + payload info from unrelated events (AJAX timeslice metrics, session trace) via a shared
paramsobject.Overview
In this PR, we remove assignments to the
paramsobject insidestoreXHR. It was possibly a legacy mechanism for passing info to the old SPA implementation. Verified these fields are not pulled fromparamsin the consumer. The consumer should be pulling these fields from the AjaxNode/events directly.Related Issue(s)
NR-582727
Testing
Added component tests for the shape of params in timeslice metrics + session trace, as well as the Ajax event.
Params:
Ajax: