chore: ActivityBridge Client Http External support#3151
Merged
Conversation
* Update ActivityBridge to handle Client external http activity kind correctly
… move common code to a central location
…es for any remaining tags
tippmar-nr
marked this pull request as ready for review
June 16, 2025 16:02
nrcventura
reviewed
Jun 16, 2025
nrcventura
approved these changes
Jun 16, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
=======================================
Coverage 82.35% 82.36%
=======================================
Files 479 479
Lines 31018 31094 +76
Branches 3526 3543 +17
=======================================
+ Hits 25545 25610 +65
- Misses 4653 4660 +7
- Partials 820 824 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityBridgeto handle Client activity kind for an external HTTP callhttp.statusTextattribute on spanEvent (exists in the spanEvent spec but was marked "optional") and refactor as needed. Did not modify existing http client instrumentation to include that attribute.