chore: Add cloud.resource_id for Azure AppServices.#3152
Merged
Conversation
tippmar-nr
reviewed
Jun 17, 2025
tippmar-nr
reviewed
Jun 17, 2025
tippmar-nr
reviewed
Jun 17, 2025
jaffinito
marked this pull request as ready for review
June 23, 2025 22:22
nrcventura
approved these changes
Jun 23, 2025
tippmar-nr
approved these changes
Jun 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
+ Coverage 82.14% 82.15% +0.01%
==========================================
Files 485 486 +1
Lines 31104 31130 +26
Branches 3546 3549 +3
==========================================
+ Hits 25549 25575 +26
Misses 4730 4730
Partials 825 825
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Azure Entity Relationships. We need the resource id for building the relationship from the AppService site and the AppService plan (apm <> infra).
Adds a new vendor model called
azureappservicethat has a single entry called "cloud.resource_id". It uses a set of three env vars to synthesize the id: WEBSITE_OWNER_NAME, WEBSITE_RESOURCE_GROUP, and WEBSITE_SITE_NAME.Includes unit tests.
Author Checklist
Reviewer Checklist