Skip to content

chore: Add cloud.resource_id for Azure AppServices.#3152

Merged
jaffinito merged 3 commits into
mainfrom
other/azure-appservice-resourceid
Jun 24, 2025
Merged

chore: Add cloud.resource_id for Azure AppServices.#3152
jaffinito merged 3 commits into
mainfrom
other/azure-appservice-resourceid

Conversation

@jaffinito

@jaffinito jaffinito commented Jun 13, 2025

Copy link
Copy Markdown
Member

Description

For Azure Entity Relationships. We need the resource id for building the relationship from the AppService site and the AppService plan (apm <> infra).

Adds a new vendor model called azureappservice that has a single entry called "cloud.resource_id". It uses a set of three env vars to synthesize the id: WEBSITE_OWNER_NAME, WEBSITE_RESOURCE_GROUP, and WEBSITE_SITE_NAME.

Includes unit tests.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

Comment thread src/Agent/NewRelic/Agent/Core/Utilization/VendorInfo.cs
Comment thread src/Agent/NewRelic/Agent/Core/Config/Configuration.cs
Comment thread src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd
@jaffinito
jaffinito marked this pull request as ready for review June 23, 2025 22:22
@jaffinito
jaffinito requested a review from a team as a code owner June 23, 2025 22:22
@jaffinito
jaffinito merged commit 0126350 into main Jun 24, 2025
181 of 183 checks passed
@jaffinito
jaffinito deleted the other/azure-appservice-resourceid branch June 24, 2025 14:56
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.15%. Comparing base (2a58163) to head (085f634).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
+ Coverage   82.14%   82.15%   +0.01%     
==========================================
  Files         485      486       +1     
  Lines       31104    31130      +26     
  Branches     3546     3549       +3     
==========================================
+ Hits        25549    25575      +26     
  Misses       4730     4730              
  Partials      825      825              
Flag Coverage Δ
Agent 83.42% <100.00%> (+0.01%) ⬆️
Profiler 70.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.63% <100.00%> (+<0.01%) ⬆️
.../Agent/Core/Configuration/ReportedConfiguration.cs 95.52% <100.00%> (+0.01%) ⬆️
...ent/Core/Utilization/AzureAppServiceVendorModel.cs 100.00% <100.00%> (ø)
...gent/NewRelic/Agent/Core/Utilization/VendorInfo.cs 90.56% <100.00%> (+0.56%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants