ci: Fix CI for .NET 10 SDK and Windows runner compatibility#3476
Merged
Conversation
…gration test jobs which now use the beta image with VS2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
- Coverage 81.69% 81.68% -0.02%
==========================================
Files 508 508
Lines 33972 33972
Branches 4006 4006
==========================================
- Hits 27753 27749 -4
- Misses 5260 5263 +3
- Partials 959 960 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nrcventura
reviewed
Mar 11, 2026
| dotnet nuget list source | ||
| Write-Host "MSBuild.exe -restore -m -p:Configuration=Release -p:AllowUnsafeBlocks=true ${{ env.nuget_helper_project_path }}" | ||
| MSBuild.exe -restore -m -p:Configuration=Release -p:AllowUnsafeBlocks=true ${{ env.nuget_helper_project_path }} | ||
| dotnet build --configuration Release ${{ env.nuget_helper_project_path }} |
Member
There was a problem hiding this comment.
Does the build no longer require the AllowUnsafeBlocks setting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10.0.19041.0) with dynamic glob-based discovery, and add required/fd SHA256flag for newer signtool versionswindows-2025-vs2026(beta) runners for integration test build and run jobs, which provides MSBuild 18.x needed by .NET 10 SDK 10.0.200+dotnet buildin siteextension_release workflow, removing unnecessarysetup-msbuilddependencyContext
.NET 10 SDK 10.0.200 was released and
setup-dotnetwithdotnet-version: 10.0.xbegan resolving to it. Unlike the 10.0.1xx band (which requires MSBuild 17.14+), the 10.0.2xx band requires MSBuild 18.0+. This broke integration test builds onwindows-2022runners which only have VS 2022 / MSBuild 17.x.Separately, moving to
windows-2025runners exposed two issues in the MSI installer project:signtool.exepath was hardcoded to SDK version10.0.19041.0which doesn't exist on newer runnerssigntool.exeversions require an explicit/fddigest algorithm flagTest plan
build-integration-testsjob succeeds onwindows-2025-vs2026build-unbounded-testsjob succeeds onwindows-2025-vs2026run-integration-testsjobs passrun-unbounded-testsjobs passsiteextension_releaseworkflow NuGetHelper build succeeds withdotnet build🤖 Generated with Claude Code