Skip to content

feat(agent): update instrumentation to be compatible with MongoDB 2.x #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hahuja2 merged 3 commits into from
Feb 3, 2026
Merged

feat(agent): update instrumentation to be compatible with MongoDB 2.x #1154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2961fc9
remove Executable interface check
hahuja2 Jan 5, 2026
be684aa
remove unnecessary check
hahuja2 Jan 22, 2026
7f2f608
remove label
hahuja2 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions agent/lib_mongodb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,10 @@ NR_PHP_WRAPPER(nr_mongodb_operation_before) {
NR_PHP_WRAPPER_END

NR_PHP_WRAPPER(nr_mongodb_operation_after) {
const char* this_klass = "MongoDB\\Operation\\Executable";
zval* collection = NULL;
zval* database = NULL;
zval* server = NULL;
zval* this_var = NULL;
bool discard_segment = false;
nr_datastore_instance_t instance = {
.host = NULL,
.port_path_or_id = NULL,
Expand All @@ -218,18 +216,8 @@ NR_PHP_WRAPPER(nr_mongodb_operation_after) {
},
};
#pragma GCC diagnostic pop
/*
* We check for the interface all Collection operations extend, rather than
* their specific class. Not all operations have the properties we need but
* the ones we hook do (as of mongo-php-library v.1.1).
*/

this_var = nr_php_scope_get(NR_EXECUTE_ORIG_ARGS);
if (!nr_php_object_instanceof_class(this_var, this_klass)) {
nrl_verbosedebug(NRL_FRAMEWORK, "%s: operation is not %s", __func__,
this_klass);
discard_segment = true;
goto leave;
}

collection = nr_php_get_zval_object_property(this_var, "collectionName");
if (nr_php_is_zval_valid_string(collection)) {
Expand All @@ -245,12 +233,7 @@ NR_PHP_WRAPPER(nr_mongodb_operation_after) {
nr_mongodb_get_host_and_port_path_or_id(server, &instance.host,
&instance.port_path_or_id);

leave:
if (discard_segment) {
nr_segment_discard(&auto_segment);
} else {
nr_segment_datastore_end(&auto_segment, &params);
}
nr_segment_datastore_end(&auto_segment, &params);
nr_php_arg_release(&server);
nr_php_scope_release(&this_var);
nr_free(instance.host);
Expand Down
Loading