Skip to content

fix(agent): allow mysqli parameter binding in execute#1172

Open
ZNeumann wants to merge 8 commits intodevfrom
zjn/mysqli
Open

fix(agent): allow mysqli parameter binding in execute#1172
ZNeumann wants to merge 8 commits intodevfrom
zjn/mysqli

Conversation

@ZNeumann
Copy link
Copy Markdown
Contributor

@ZNeumann ZNeumann commented Mar 4, 2026

fixes instrumentation of mysqli when binding in execute. This feature was introduced in PHP 8.1 https://wiki.php.net/rfc/mysqli_bind_in_execute

@newrelic-php-agent-bot
Copy link
Copy Markdown

newrelic-php-agent-bot commented Mar 4, 2026

Test Suite Status Result
Multiverse 6/18 passing
SOAK 142/142 passing

@ZNeumann ZNeumann requested a review from zsistla March 4, 2026 19:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.37%. Comparing base (d7bc3fb) to head (ffb80a1).
⚠️ Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
agent/php_explain_mysqli.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1172      +/-   ##
==========================================
+ Coverage   78.33%   78.37%   +0.04%     
==========================================
  Files         193      193              
  Lines       28250    28305      +55     
==========================================
+ Hits        22129    22185      +56     
+ Misses       6121     6120       -1     
Flag Coverage Δ
agent-for-php-7.2 78.25% <76.92%> (?)
agent-for-php-7.3 78.27% <76.92%> (-0.01%) ⬇️
agent-for-php-7.4 78.15% <76.92%> (-0.01%) ⬇️
agent-for-php-8.0 77.68% <72.72%> (-0.01%) ⬇️
agent-for-php-8.1 77.93% <100.00%> (+0.02%) ⬆️
agent-for-php-8.2 77.55% <100.00%> (?)
agent-for-php-8.3 77.62% <100.00%> (+0.02%) ⬆️
agent-for-php-8.4 77.64% <100.00%> (+0.02%) ⬆️
agent-for-php-8.5 76.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bduranleau-nr bduranleau-nr added this to the next-release milestone Mar 9, 2026
@bduranleau-nr bduranleau-nr self-requested a review March 9, 2026 17:11
@lavarou lavarou requested a review from zsistla March 16, 2026 20:49
@zsistla
Copy link
Copy Markdown
Contributor

zsistla commented Mar 24, 2026

Could you please add a test similar to this one: https://github.com/newrelic/newrelic-php-agent/blob/main/tests/integration/mysqli/test_bind_param_object_oo.php#L167
So we can verify no nefarious garbage collections?

@zsistla zsistla removed this from the next-release milestone Mar 26, 2026
@hahuja2 hahuja2 added this to the next-release milestone Apr 6, 2026
@hahuja2 hahuja2 added the on hold This issue or pull request is necessary, but better suited for the future label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold This issue or pull request is necessary, but better suited for the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants