fix(agent): allow mysqli parameter binding in execute#1172
Open
fix(agent): allow mysqli parameter binding in execute#1172
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1172 +/- ##
==========================================
+ Coverage 78.33% 78.37% +0.04%
==========================================
Files 193 193
Lines 28250 28305 +55
==========================================
+ Hits 22129 22185 +56
+ Misses 6121 6120 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zsistla
reviewed
Mar 9, 2026
zsistla
reviewed
Mar 9, 2026
Contributor
|
Could you please add a test similar to this one: https://github.com/newrelic/newrelic-php-agent/blob/main/tests/integration/mysqli/test_bind_param_object_oo.php#L167 |
zsistla
reviewed
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes instrumentation of mysqli when binding in execute. This feature was introduced in PHP 8.1 https://wiki.php.net/rfc/mysqli_bind_in_execute