Skip to content

fix(axiom): ensure unnamed spans are not recorded#1197

Open
hahuja2 wants to merge 2 commits intodevfrom
infinite_tracing_fix
Open

fix(axiom): ensure unnamed spans are not recorded#1197
hahuja2 wants to merge 2 commits intodevfrom
infinite_tracing_fix

Conversation

@hahuja2
Copy link
Copy Markdown
Contributor

@hahuja2 hahuja2 commented Apr 9, 2026

This PR adds a fix that ensures only named segments are pushed to the span_queue. This ensures that unnamed spans are not recorded.

@newrelic-php-agent-bot
Copy link
Copy Markdown

newrelic-php-agent-bot commented Apr 9, 2026

Test Suite Status Result
Multiverse 18/18 passing
SOAK 135/135 passing

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.06%. Comparing base (18174dd) to head (b37e028).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1197   +/-   ##
=======================================
  Coverage   80.05%   80.06%           
=======================================
  Files         189      189           
  Lines       27699    27699           
=======================================
+ Hits        22174    22176    +2     
+ Misses       5525     5523    -2     
Flag Coverage Δ
agent-for-php-7.2 79.97% <100.00%> (ø)
agent-for-php-7.3 79.99% <100.00%> (?)
agent-for-php-7.4 79.86% <100.00%> (ø)
agent-for-php-8.0 79.45% <100.00%> (ø)
agent-for-php-8.1 79.67% <100.00%> (ø)
agent-for-php-8.2 79.27% <100.00%> (ø)
agent-for-php-8.3 79.35% <100.00%> (ø)
agent-for-php-8.4 79.37% <100.00%> (ø)
agent-for-php-8.5 78.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hahuja2 hahuja2 requested review from mfulb and zsistla April 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants