Skip to content

DONOTMERGE feat(agent): Fiber Support#1198

Draft
zsistla wants to merge 1 commit intodevfrom
feat/fibers
Draft

DONOTMERGE feat(agent): Fiber Support#1198
zsistla wants to merge 1 commit intodevfrom
feat/fibers

Conversation

@zsistla
Copy link
Copy Markdown
Contributor

@zsistla zsistla commented Apr 10, 2026

No description provided.

* show_fiber functionality; indentations align with show_execs; the
special keyword is "show_fibers"
* basic user function fiber usage - does not include anything with
special instrumentation. Instrumentation of internal functions have not
been tested; although the show_fibers properly detects them.
* a few basic tests
* some get_current_segment, start_segment have been updated
* added values to track global asynchronous context (the actual context
we are in) and txn context (the context the txn is currently working
with which can be modified with set_current_segment)
* modified nr_txn_get_current_span_id for context to be passed
* added nr_txn_get_current_context
* added a few axiom unit tests

This is not the complete implementation, but will provide a base for
other PRs to iterate on.
@zsistla zsistla added this to the fiber milestone Apr 10, 2026
@zsistla zsistla added the on hold This issue or pull request is necessary, but better suited for the future label Apr 10, 2026
@newrelic-php-agent-bot
Copy link
Copy Markdown

newrelic-php-agent-bot commented Apr 10, 2026

Test Suite Status Result
Multiverse 12/18 passing
SOAK 135/135 passing

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 59.28571% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.92%. Comparing base (18174dd) to head (3b4a520).

Files with missing lines Patch % Lines
agent/php_execute.c 11.53% 46 Missing ⚠️
agent/php_observer.c 83.33% 7 Missing ⚠️
agent/php_nrini.c 33.33% 2 Missing ⚠️
axiom/nr_txn.c 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1198      +/-   ##
==========================================
- Coverage   80.05%   79.92%   -0.13%     
==========================================
  Files         189      189              
  Lines       27699    27789      +90     
==========================================
+ Hits        22174    22211      +37     
- Misses       5525     5578      +53     
Flag Coverage Δ
agent-for-php-7.2 ?
agent-for-php-7.3 80.00% <89.36%> (?)
agent-for-php-7.4 79.88% <89.36%> (+0.01%) ⬆️
agent-for-php-8.0 79.46% <90.38%> (+0.01%) ⬆️
agent-for-php-8.1 79.56% <59.28%> (-0.11%) ⬇️
agent-for-php-8.2 79.17% <59.28%> (-0.11%) ⬇️
agent-for-php-8.3 79.24% <59.28%> (-0.11%) ⬇️
agent-for-php-8.4 79.26% <59.28%> (-0.11%) ⬇️
agent-for-php-8.5 78.58% <59.28%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold This issue or pull request is necessary, but better suited for the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants