Open
Conversation
jsumners-nr
force-pushed
the
load-indicator
branch
from
775f601 to
d888b4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #4. It does not add any indicators for materializing a large result set query.
Instead of trying to load the interface, designing a progress indicator for the TUI, and then attempting to load the data, we opt for a simple CLI message based indicator. The addition of the "dump remote payloads and exit" feature kind of complicated adding a TUI based indicator. If we are dumping remote payloads, there's no reason to start the TUI. But we have to load the file before we can dump the payloads. So this is an easy to implement solution.
Example in action