chore: Reorganized the test utilities in AWS versioned tests#3895
Open
jsumners-nr wants to merge 1 commit intonewrelic:mainfrom
Open
chore: Reorganized the test utilities in AWS versioned tests#3895jsumners-nr wants to merge 1 commit intonewrelic:mainfrom
jsumners-nr wants to merge 1 commit intonewrelic:mainfrom
Conversation
jsumners-nr
force-pushed
the
reorg-aws-tests
branch
from
ddd92c2 to
7b0622b
Compare
jsumners-nr
force-pushed
the
reorg-aws-tests
branch
from
7b0622b to
c5aec52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
==========================================
- Coverage 97.83% 97.72% -0.12%
==========================================
Files 493 493
Lines 59840 59842 +2
Branches 1 1
==========================================
- Hits 58546 58479 -67
- Misses 1294 1363 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the SNS and SQS refactors I added
test-utils/to contain utility functions and what-have-you for the various test suites in theaws-sdk-v3versioned tests. This PR refactors the utilities that already existed within thecommon.jsfile into individual files under thetest-utils/directory. I find that this makes it far easier to learn what utilities are available for use due to the file tree showing each one of them.