Skip to content

chore: Updated Undici tests to cover version 8#3896

Merged
jsumners-nr merged 1 commit intonewrelic:mainfrom
jsumners-nr:undici-ci-fix
Apr 13, 2026
Merged

chore: Updated Undici tests to cover version 8#3896
jsumners-nr merged 1 commit intonewrelic:mainfrom
jsumners-nr:undici-ci-fix

Conversation

@jsumners-nr
Copy link
Copy Markdown
Contributor

@jsumners-nr jsumners-nr commented Apr 13, 2026

This PR updates the versioned tests configuration for undici such that it is run on the correct Node.js + undici versions.

Related: nodejs/undici#5024

@jsumners-nr jsumners-nr marked this pull request as ready for review April 13, 2026 12:58
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (ff677a2) to head (a6c5285).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3896      +/-   ##
==========================================
- Coverage   97.81%   97.70%   -0.12%     
==========================================
  Files         491      491              
  Lines       59709    59709              
  Branches        1        1              
==========================================
- Hits        58405    58338      -67     
- Misses       1304     1371      +67     
Flag Coverage Δ
integration-tests-cjs-20.x 74.27% <ø> (ø)
integration-tests-cjs-22.x 74.49% <ø> (ø)
integration-tests-cjs-24.x 75.14% <ø> (+<0.01%) ⬆️
integration-tests-esm-20.x 53.64% <ø> (ø)
integration-tests-esm-22.x 53.68% <ø> (ø)
integration-tests-esm-24.x 54.88% <ø> (ø)
unit-tests-20.x 89.77% <ø> (+<0.01%) ⬆️
unit-tests-22.x 89.79% <ø> (ø)
unit-tests-24.x 89.79% <ø> (ø)
versioned-tests-20.x 80.81% <ø> (-0.24%) ⬇️
versioned-tests-22.x 80.82% <ø> (-0.24%) ⬇️
versioned-tests-24.x 80.72% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsumners-nr jsumners-nr merged commit f27e75f into newrelic:main Apr 13, 2026
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Apr 13, 2026
@jsumners-nr jsumners-nr deleted the undici-ci-fix branch April 13, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

3 participants