Kondracek/win hostprocess#1361
Closed
kondracek-nr wants to merge 4 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 53 53
Lines 3666 3666
=======================================
Hits 2728 2728
Misses 766 766
Partials 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kondracek-nr
force-pushed
the
kondracek/win-hostprocess
branch
6 times, most recently
from
97daa51 to
51a222a
Compare
kondracek-nr
force-pushed
the
kondracek/win-hostprocess
branch
2 times, most recently
from
80d189f to
d6c469e
Compare
chore: use container sandbox path when in privileged mode chore: add tests for hostprocess & privileged support in windows chore: allow overriding privilged for windows
kondracek-nr
force-pushed
the
kondracek/win-hostprocess
branch
from
d6c469e to
b852a15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
May be considered a breaking change to users who are currently running Linux pods with elevated permissions & Windows pods in (previously hardcoded) unprivileged mode. By default, Windows pods would take the global/chart level privileged setting & run as HostProcess pods, which may be considered a security risk even by companies already running Linux pods in privileged mode.
We may want to swap the default setting for Windows to false.
Type of change
Checklist: