Skip to content

fix(schema): add UNION type support to query generation #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranav-new-relic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(schema): add UNION type support to query generation #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/schema/kind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ const (
KindNonNull Kind = "NON_NULL"
KindObject Kind = "OBJECT"
KindScalar Kind = "SCALAR"
KindUnion Kind = "UNION"
)
15 changes: 13 additions & 2 deletions internal/schema/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (t *Type) GetQueryStringFields(s *Schema, depth, maxDepth int, isMutation b
lastKind := kinds[len(kinds)-1]

switch lastKind {
case KindObject, KindInterface:
case KindObject, KindInterface, KindUnion:
if depth > maxDepth {
continue
}
Expand All @@ -139,13 +139,24 @@ func (t *Type) GetQueryStringFields(s *Schema, depth, maxDepth int, isMutation b
"depth": depth,
"isMutation": isMutation,
"name": field.Name,
"typeName": subT.Name,
"typeKind": subT.Kind,
}).Trace("skipping, all sub-fields require arguments")
continue
}

log.WithFields(log.Fields{
"depth": depth,
"isMutation": isMutation,
"name": field.Name,
"typeName": subT.Name,
"typeKind": subT.Kind,
"contentLen": len(subTContent),
}).Trace("expanding field")

// Add the field
lines = append(lines, field.Name+" {")
if lastKind == KindInterface {
if lastKind == KindInterface || lastKind == KindUnion {
lines = append(lines, "\t__typename")
}

Expand Down
Loading