Skip to content

πŸš€ 3단계 - μ™ΈλΆ€ μ‹œμŠ€ν…œ 격리#25

Open
stoneHee99 wants to merge 5 commits intonext-step:stonehee99from
stoneHee99:step3
Open

πŸš€ 3단계 - μ™ΈλΆ€ μ‹œμŠ€ν…œ 격리#25
stoneHee99 wants to merge 5 commits intonext-step:stonehee99from
stoneHee99:step3

Conversation

@stoneHee99
Copy link
Copy Markdown

@stoneHee99 stoneHee99 commented Sep 27, 2025

μ•ˆλ…•ν•˜μ„Έμš” μ„±ν˜„λ‹˜!
3단계 λ―Έμ…˜ μ™„λ£Œν•˜μ—¬ 리뷰 μš”μ²­ λ“œλ¦½λ‹ˆλ‹€!

이번 λ―Έμ…˜μ€ νŠΉλ³„νžˆ!! 2μ£Όμ°¨ λ―Έμ…˜μ—μ„œ 받은 인수쑰건 μ‹œλ‚˜λ¦¬μ˜€ (Feature) ν‘œν˜„μ„ ν”Όλ“œλ°± λ°˜μ˜ν•˜λŠ”κ±°μ— 쀑점을 λ‘μ–΄λ΄€μŠ΅λ‹ˆλ‹€!
κ·ΈλŸ¬λ‹€λ³΄λ‹ˆ μ‹œλ‚˜λ¦¬μ˜€λ₯Ό 잘 μž‘μ„±ν•˜λ©΄ κ°„λ‹¨ν•œ μ‹œλ‚˜λ¦¬μ˜€λŠ” λ³„λ„μ˜ ν…ŒμŠ€νŠΈ ν”½μŠ€μ³λ₯Ό λ§Œλ“€ ν•„μš” 없이 (쀑볡 없이) ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•  수 μžˆκ² λ”λΌκ΅¬μš” γ…Žγ…Ž

그리고 wiremock의 μ‚¬μš©μ΄ μ–΄μƒ‰ν•΄μ„œ AI λ„κ΅¬μ˜ νž˜μ„ λΉŒλ €μ„œ μž‘μ„±ν•΄λ³΄μ•˜λŠ”λ° 잘 μž‘μ„±ν•œκ±΄μ§€ κΆκΈˆν•˜λ„€μš”!! πŸ€”

리뷰 잘 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€ 🫑
그리고 ꡐ윑 κΈ°κ°„ λ™μ•ˆ 많이 λ°°μ› μŠ΅λ‹ˆλ‹€! 그리고 μ•žμœΌλ‘œλ„ μž˜λΆ€νƒλ“œλ¦½λ‹ˆλ‹· 😁

boorownie
boorownie requested changes Sep 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@boorownie boorownie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•ˆλ…•ν•˜μ„Έμš” μ„ν¬λ‹˜!
3단계 μš”κ΅¬μ‚¬ν•­ 잘 μˆ˜ν–‰ν•΄μ£Όμ…¨μŠ΅λ‹ˆλ‹€ πŸ‘

싀무에 인수 ν…ŒμŠ€νŠΈλ₯Ό κ΅¬μΆ•ν•˜κΈ° μœ„ν•΄μ„œλŠ” μ—¬λŸ¬κ°€μ§€ κ³ λ €ν•΄μ•Όν•  뢀뢄이 λ§Žμ€λ°μš”~
그런 λΆ€λΆ„λ“€ λͺ¨λ‘λ₯Ό 미리 μ€€λΉ„ν•  순 μ—†μ§€λ§Œ, λͺ‡ κ°€μ§€λŠ” κ²½ν—˜ν•΄λ³΄λ©΄ μ‹€μ œ ꡬ좕할 λ•Œ 도움이 될 수 μžˆλ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€!

κ΄€λ ¨ν•΄μ„œ λͺ‡ 가지 μ½”λ©˜νŠΈλ₯Ό λ‚¨κ²¨λ‘μ—ˆλŠ”λ°μš”~ μ°Έκ³ ν•΄λ³΄μ‹œκ³  계속 μ§„ν–‰ν•΄μ£Όμ„Έμš”!
ν’λΆ€ν•œ κ²½ν—˜μ„ μœ„ν•΄μ„œ μ„ νƒλ―Έμ…˜μ„ 살짝 μ°Έκ³ ν•΄μ„œ 쑰금 더 ν’λΆ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό κ΅¬μΆ•ν•œ λ’€ λ―Έμ…˜μ„ 완성해주셔도 μ’‹μ•„μš”!

Comment thread src/test/resources/features/kiosk-payment.feature
@@ -0,0 +1,11 @@
Feature: ν‚€μ˜€μŠ€ν¬ 결제 승인 E2E ν…ŒμŠ€νŠΈ
Copy link
Copy Markdown
Contributor

@boorownie boorownie Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kiosk - paymeny(wiremock) e2e ν…ŒμŠ€νŠΈ πŸ‘

Comment thread src/test/java/com/camping/tests/steps/KioskPaymentStepDef.java
import java.util.Map;
import org.apache.http.HttpStatus;

public class KioskPaymentStepDef {
Copy link
Copy Markdown
Contributor

@boorownie boorownie Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 ν…ŒμŠ€νŠΈ μ €μž₯μ†Œμ—λŠ” ν‚€μ˜€μŠ€ν¬ μ™Έ μ‚¬μš©μž μ˜ˆμ•½κ³Ό κ΄€λ¦¬μžλ‘œ ν˜ΈμΆœν•˜λŠ” ν…ŒμŠ€νŠΈλ„ ν¬ν•¨λ˜λŠ” μ €μž₯μ†Œμž…λ‹ˆλ‹€!

ν˜„μž¬ ν‚€μ˜€μŠ€ν¬λ‘œ ν˜ΈμΆœμ„ λ³΄λ‚΄λŠ” μŠ€ν…μ΄ KioskProductStepsκ³Ό KioskPaymentStepDef에 μœ„μΉ˜ν•΄μžˆλŠ”λ°μš”~
ν‚€μ˜€μŠ€ν¬λ‘œ ν˜ΈμΆœν•˜λŠ” λΆ€λΆ„μ˜ λ‘œμ§μ„ μŠ€ν…κ³Ό λΆ„λ¦¬ν•΄μ„œ μž¬μ‚¬μš©ν•  수 μžˆλŠ” 방법은 μ—†μ„κΉŒμš”?
κ·Έλ ‡κ²Œ 될 경우 맀번 ν…ŒμŠ€νŠΈλ₯Ό λ§Œλ“€μ–΄μ€„ λ•Œ λ§ˆλ‹€ μŠ€ν… 클래슀λ₯Ό μƒˆλ‘œ λ§Œλ“€μ–΄μ€„ ν•„μš” 없이 ν•˜λ‚˜μ˜ ν΄λž˜μŠ€μ—μ„œ 관리할 수 μžˆμ„ 것 κ°™μ•„μ„œμš”~

Copy link
Copy Markdown
Author

@stoneHee99 stoneHee99 Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΈ°μ‘΄ 2μ£Όμ°¨ λ―Έμ…˜μ—μ„œ ν–ˆλ˜ 것 처럼 API 호좜 μ±…μž„μ„ 가진 클래슀λ₯Ό λ§Œλ“€μ–΄λ³΄λ©΄ μ’‹κ² λ„€μš”!

Comment thread src/test/java/com/camping/tests/steps/KioskPaymentStepDef.java
Comment on lines +17 to +18
private int amount;
private Response response;
Copy link
Copy Markdown
Contributor

@boorownie boorownie Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μŠ€ν… ν΄λž˜μŠ€λ³„λ‘œ κ³΅μœ ν•˜λŠ” 객체가 λ”°λ‘œ κ΄€λ¦¬λ˜κ³  μžˆλŠ”λ°μš”~
μŠ€ν… 클래슀λ₯Ό λ‹€μ–‘ν•˜κ²Œ μ‚¬μš©ν•  경우 κ³΅μœ κ°€ μ–΄λ €μšΈ 것 κ°™μ•„μš”!
λ‹€μ–‘ν•œ ν΄λž˜μŠ€μ—μ„œ μƒνƒœλ₯Ό κ³΅μœ ν•  수 있게 ν•˜λ €λ©΄ μ–΄λ–»κ²Œ ν•˜λ©΄ μ’‹μ„κΉŒμš”?

Comment thread infra/docker-compose.yml
atdd-net:
external: true

x-db-env: &db_env
Copy link
Copy Markdown
Contributor

@boorownie boorownie Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν”Όλ“œλ°± 반영 πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boorownie boorownie boorownie requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stoneHee99 @boorownie