Skip to content

fix: Replace deprecated url.parse() with WHATWG URL API #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pilgrimlyieu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Replace deprecated url.parse() with WHATWG URL API #955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
631a30f
fix: fix Node deprecation warning
pilgrimlyieu Apr 21, 2026
5475be8
fix(lint): fix unused-var and useless assignment linting issue
pilgrimlyieu Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/helpers/next-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,19 @@

'use strict';

const { parse } = require('url');

/**
* Export theme config
*/
hexo.extend.helper.register('next_config', function() {
const { config, theme, url_for, __ } = this;
let hostname = config.url;

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The initial value of hostname is unused, since it is always overwritten.
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
try {
hostname = new URL(config.url).hostname || config.url;
} catch (_) {

Check failure on line 13 in scripts/helpers/next-config.js

View workflow job for this annotation

GitHub Actions / linter 

'_' is defined but never used
hostname = config.url;
}
const exportConfig = {
hostname : parse(config.url).hostname || config.url,
hostname,
root : config.root,
images : url_for(theme.images),
scheme : theme.scheme,
Expand Down
Loading