feat: endpoint to get HaRP version#41
Conversation
kyteinsky
left a comment
There was a problem hiding this comment.
Can we do automated checks for this, like an additional header in app_api for minimum supported version of harp? That is validated in the harp container and returns an error visisble in the logs.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
083fb52 to
42283fd
Compare
I thought of doing it this way initially, but it would greatly complicate the logic of work in AppAPI - where we would have to check the answers everywhere and it would be ugly. I wanted to make it not too complicated |
|
fair enough :) |
We will need this in AppAPI in the near future, some kind of endpoint so that we can tell the admins from AppAPI that their HaRP is old and not compatible with the new version of AppAPI. (as currently with DSP it is a disaster)