Skip to content

fix: validate board permission in setDoneStack method - #8190

Merged
luka-nextcloud merged 1 commit into
mainfrom
update-setDoneStack
Jul 23, 2026
Merged

fix: validate board permission in setDoneStack method#8190
luka-nextcloud merged 1 commit into
mainfrom
update-setDoneStack

Conversation

@luka-nextcloud

Copy link
Copy Markdown
Contributor

Summary

Added an explicit permission check for the board in addition to the stack, and validated that the stack belongs to the specified board in setDoneStack.

@luka-nextcloud
luka-nextcloud marked this pull request as ready for review July 23, 2026 07:42
@luka-nextcloud
luka-nextcloud requested a review from grnd-alt as a code owner July 23, 2026 07:42
Comment thread lib/Service/StackService.php Outdated
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@github-actions

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96817 was 96706 (+0.11%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt

Copy link
Copy Markdown
Member

/backport to stable34

@luka-nextcloud
luka-nextcloud merged commit cde06ab into main Jul 23, 2026
43 of 45 checks passed
@luka-nextcloud
luka-nextcloud deleted the update-setDoneStack branch July 23, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants