Skip to content

fix(attachment-deletion): add attachment type to delete endpoint - #8260

Merged
grnd-alt merged 1 commit into
stable34from
fix/delete-attachment
Aug 12, 2026
Merged

fix(attachment-deletion): add attachment type to delete endpoint#8260
grnd-alt merged 1 commit into
stable34from
fix/delete-attachment

Conversation

@silverkszlo

Copy link
Copy Markdown
Contributor
  • Target version: stable34

Summary

Currently it is not possible to delete an attachment from a Deck card on 1.18.3/stable34. On main that is fixed. This PR adds the attachment type to the DELETE endpoints (as it was done in main).

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

Signed-off-by: silver <s.szmajduch@posteo.de>
Assisted-by: ClaudeCode:claude-sonnet-5
@github-actions

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 97747 was 93102 (+4.98%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
grnd-alt merged commit 431f879 into stable34 Aug 12, 2026
41 of 43 checks passed
@grnd-alt
grnd-alt deleted the fix/delete-attachment branch August 12, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants