Skip to content

fix(navigation): drop active board icon fill override - #8264

Merged
grnd-alt merged 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/7539-dark-mode-active-board-icon-color
Aug 14, 2026
Merged

fix(navigation): drop active board icon fill override#8264
grnd-alt merged 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/7539-dark-mode-active-board-icon-color

Conversation

@xhon-pelushi

@xhon-pelushi xhon-pelushi commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the active-board actions icon fill override so nextcloud-vue tertiary buttons keep --color-main-text.

Fixes #7539

Test plan

  • Dark mode: select a board in the sidebar and confirm the "..." actions icon is readable
  • Confirm inactive boards still look correct

@grnd-alt grnd-alt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhon-pelushi thanks also for taking your time on this!
I think the normal color for the tertiary button should already be --color-main-text from the nextcloud-vue library, so we can just remove that entire css block?

@xhon-pelushi
xhon-pelushi force-pushed the fix/7539-dark-mode-active-board-icon-color branch from 5e9e62a to 814e059 Compare August 14, 2026 03:40
@xhon-pelushi

Copy link
Copy Markdown
Contributor Author

Thanks @grnd-alt — removed the entire :deep(.active) fill override so the tertiary button keeps the nextcloud-vue default (--color-main-text).

@xhon-pelushi xhon-pelushi changed the title fix(navigation): readable actions icon on active board in dark mode fix(navigation): drop active board icon fill override Aug 14, 2026
Rely on nextcloud-vue tertiary button default (--color-main-text)
instead of overriding the active board actions icon fill.

Fixes nextcloud#7539

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@xhon-pelushi
xhon-pelushi force-pushed the fix/7539-dark-mode-active-board-icon-color branch from 814e059 to 162e2b0 Compare August 14, 2026 03:43
@grnd-alt
grnd-alt self-requested a review August 14, 2026 07:23
@grnd-alt
grnd-alt enabled auto-merge August 14, 2026 07:24
@grnd-alt
grnd-alt merged commit 9eaaf47 into nextcloud:main Aug 14, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small dark mode issue

2 participants