Skip to content

Fix: Handle invalid form hashes correctly#2655

Merged
Chartman123 merged 1 commit intomainfrom
fix/2651
Mar 30, 2025
Merged

Fix: Handle invalid form hashes correctly#2655
Chartman123 merged 1 commit intomainfrom
fix/2651

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

@Chartman123 Chartman123 commented Mar 24, 2025

This fixes #2651 by correctly catching the NotFoundException in the backend and passing a corresponding value to the inital state of the app.

The formId is then checked against the defined value and routeAllowed returns false which then shows the correct error message that the form could not be found.

@Chartman123 Chartman123 added bug Something isn't working 2. developing Work in progress labels Mar 24, 2025
@Chartman123 Chartman123 self-assigned this Mar 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.31%. Comparing base (f48d88b) to head (d4ef335).
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2655      +/-   ##
============================================
- Coverage     43.34%   43.31%   -0.04%     
- Complexity      887      888       +1     
============================================
  Files            78       78              
  Lines          3368     3371       +3     
============================================
  Hits           1460     1460              
- Misses         1908     1911       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123 Chartman123 force-pushed the fix/2651 branch 3 times, most recently from bbeeecb to 7386c48 Compare March 24, 2025 21:34
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 marked this pull request as ready for review March 24, 2025 21:46
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2025
@Chartman123 Chartman123 requested review from Koc and susnux March 24, 2025 21:46
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Mar 24, 2025
@Chartman123 Chartman123 merged commit cd64b27 into main Mar 30, 2025
53 of 56 checks passed
@Chartman123 Chartman123 deleted the fix/2651 branch March 30, 2025 11:26
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal server error when opening link to deleted form

2 participants