fix(Action): await navigation and handle router rejections#4586
Open
fix(Action): await navigation and handle router rejections#4586
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
susnux
reviewed
Apr 22, 2026
| // real failures from the user's perspective — the target view is reached. | ||
| const name = (e as { name?: string })?.name | ||
| const message = (e as { message?: string })?.message ?? '' | ||
| if (name === 'NavigationDuplicated' || /Redirected/.test(message)) { |
Contributor
There was a problem hiding this comment.
Those should already be handled by file router in server (if not fixed there)
Member
Author
There was a problem hiding this comment.
NavigationDuplicated is handled at the server router layer (so my original catch for it was redundant), but Redirected is not handled anywhere, it bubbles as an uncaught promise rejection from every goToRoute call in every app. Neverthless, it should be handled there too.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4524 added fileid to the route params but left two async-contract bugs in the action itself: goToRoute wasn't awaited, and exec returned null (falsy, reported as failed to the v4 FileAction executor).
This PR awaits the navigation and returns true on success. Without this, the stale-route failure path in #4499 remains observable on the top-level team-folder click path even once the server-side router fix ships.
Adds two E2E smoke cases asserting the observable behavior of clicking a team folder from the Team folders view.