Conversation
Signed-off-by: Cristian <cristianvargasvalencia@gmail.com>
Signed-off-by: Cristian <cristianvargasvalencia@gmail.com>
cdvv7788
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
thank you for your pull request :) i will have a look asap |
GretaD
left a comment
GretaD
left a comment
There was a problem hiding this comment.
it works well, thank you again
|
please fix the lint and we can merge it :) |
|
/backport to stable5.7 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
MoveModal reappearing after bulk move (#12661)
fixes #12661
The MoveModal was nested inside the v-if="selectMode" div. During a bulk move, envelopes are removed from the store, which empties the selection, which flips selectMode to false — destroying the MoveModal before it can emit @close. The showMoveModal flag stays true, so the modal reappears on the next selection. Fixed by moving the MoveModal component to the root level of the template (matching how TagModal is already placed), so its lifecycle depends only on its own v-if="showMoveModal".
Missing "important" icon in multi-select quick actions (#12149)
The template used
<ImportantIcon>but the component was never imported or registered. Added the missing import of LabelVariant.vue and registered it in the components block.