refactor(db): Introduce new API for entities#1595
Open
CarlSchwan wants to merge 5 commits into
Open
Conversation
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
changed the title
Signed-off-by: Carl Schwan <carlschwan@kde.org>
come-nc
reviewed
Jun 11, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
come-nc
reviewed
Jun 11, 2026
| } | ||
|
|
||
| /** @var Column $columnAttribute */ | ||
| $columnAttribute = $columnAttributes[0]->newInstance(); |
Collaborator
There was a problem hiding this comment.
Check that there is only one column attribute on the property?
| /** @var list<\ReflectionAttribute<Id>> $ids */ | ||
| $ids = $property->getAttributes(Id::class, \ReflectionAttribute::IS_INSTANCEOF); | ||
| if ($ids !== []) { | ||
| $this->idProperty = $property; |
Collaborator
There was a problem hiding this comment.
Show an error if there is already another id property?
| * @param array<string, mixed> $row | ||
| * @return T | ||
| */ | ||
| private function mapRowToEntity(mixed $row): object { |
Collaborator
There was a problem hiding this comment.
Suggested change
| private function mapRowToEntity(mixed $row): object { | |
| private function mapRowToEntity(array $row): object { |
come-nc
reviewed
Jun 11, 2026
| ->executeStatement(); | ||
|
|
||
| if (!$isSnowflake) { | ||
| $primaryProperty->setValue($entity, $insert->getLastInsertId()); |
Collaborator
There was a problem hiding this comment.
what if no primary property? Should throw or adapt
| $type = $this->getParameterType($this->_mappingColumnToTypes[$column], is_array($value)); | ||
| if (is_array($value)) { | ||
| // IN expression | ||
| $qb->andWhere($qb->expr()->in($column, $qb->createNamedParameter($value, $type))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be upstreamed later to server
🤖 AI (if applicable)