fix(security): 2 improvements across 2 files#854
Open
tomaioo wants to merge 2 commits intonextcloud:masterfrom
Open
fix(security): 2 improvements across 2 files#854tomaioo wants to merge 2 commits intonextcloud:masterfrom
tomaioo wants to merge 2 commits intonextcloud:masterfrom
Conversation
- Security: Weak cryptographic parameters for vault/client-side encryption - Security: Potential storage of vault password in browser localStorage Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Weak cryptographic parameters for vault/client-side encryption - Security: Potential storage of vault password in browser localStorage Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:js/app/services/encryptservice.js:L31The encryption configuration uses PBKDF iterations set to 1000 and an authentication tag size (
ts) of 64 bits for SJCL CCM mode. For a password manager context, these settings are weak by modern standards and reduce resistance against brute-force and forgery attempts.Solution
Increase KDF work factor substantially (e.g., PBKDF2 >= 100k+ iterations or migrate to Argon2/scrypt if possible), and use a 128-bit authentication tag. Re-evaluate all crypto defaults against current best practices and threat model.
Changes
js/app/services/encryptservice.js(modified)js/app/services/settingsservice.js(modified)