Display delegated section in common settings for non-admin#55511
Display delegated section in common settings for non-admin#55511printminion-co wants to merge 1 commit intonextcloud:masterfrom
Conversation
|
(sorry, I confused tabs, ignore my last changes here) |
f942e16 to
189c703
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
6bab729 to
2643ab1
Compare
…or non-admin IDeclarativeSettingsForm can't be delegated and can be shown only to admin. Lets not load IDeclarativeSettings for non admins. Otherwise we get "Access forbidden" while displaying /settings/admin and prevent to show delegated sections to non admin like: Background jobs OCA\Settings\Settings\Admin\Server Email server OCA\Settings\Settings\Admin\Mail Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2643ab1 to
2335869
Compare
Summary
IDeclarativeSettingsForm can't be delegated and can be shown only to admin. Lets not load IDeclarativeSettings for non admins. Otherwise we get "Access forbidden" while displaying /settings/admin and prevent to show delegated sections to non admin like:
Background jobs OCA\Settings\Settings\Admin\Server
Email server OCA\Settings\Settings\Admin\Mail
Before state
login and check Administration * Basic Settings
e.g. open http://localhost:8080/index.php/settings/admin
Observe: Access forbidden
After state
Todo
Checklist
3. to review, feature component)stable32)