fix(ObjectStore/S3): switch to more reliable doesObjectExistV2#58840
Merged
joshtrichards merged 4 commits intomasterfrom Apr 29, 2026
Merged
fix(ObjectStore/S3): switch to more reliable doesObjectExistV2#58840joshtrichards merged 4 commits intomasterfrom
joshtrichards merged 4 commits intomasterfrom
Conversation
The non-v2 version is deprecated, but more importantly the V2 implementation makes fewer assumptions about ambiguous or unexpected status codes. For example, a 403 would result in a false (object does not exist) in V1, but that's not necessarily what that means. V2 returns true/false on a much more narrow set of scenarios. And it throws for all others so they can be diagnosed properly. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
approved these changes
Mar 12, 2026
come-nc
approved these changes
Mar 17, 2026
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…-S3-doesObjectExistV2 # Conflicts: # lib/private/Files/ObjectStore/S3ObjectTrait.php Co-authored-by: joshtrichards <1731941+joshtrichards@users.noreply.github.com>
Contributor
Merge conflicts resolved in commit |
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The non-v2 version is deprecated, but more importantly the V2 implementation makes fewer assumptions about ambiguous or unexpected status codes. For example, a 403 would result in a false (object does not exist) in V1, but that's not necessarily what that means. V2 returns true/false on a much more narrow set of scenarios. And it throws for all others so they can be diagnosed properly.
Refs:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)