Skip to content

fix(theming): deprecate OCA.Theming and move to capabilities#59089

Merged
skjnldsv merged 3 commits intomasterfrom
fix/expand-theming-capabilities
Mar 24, 2026
Merged

fix(theming): deprecate OCA.Theming and move to capabilities#59089
skjnldsv merged 3 commits intomasterfrom
fix/expand-theming-capabilities

Conversation

@skjnldsv
Copy link
Copy Markdown
Member

@skjnldsv skjnldsv commented Mar 19, 2026

Summary

We should refrain from using OCA.Theming
We should be able to do everything we want with capabilities

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@skjnldsv skjnldsv added this to the Nextcloud 34 milestone Mar 19, 2026
@skjnldsv skjnldsv self-assigned this Mar 19, 2026
@skjnldsv skjnldsv requested a review from a team as a code owner March 19, 2026 18:07
@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 19, 2026
@skjnldsv skjnldsv requested review from CarlSchwan, leftybournes, provokateurin and sorbaugh and removed request for a team March 19, 2026 18:08
@skjnldsv skjnldsv force-pushed the fix/expand-theming-capabilities branch from f96535b to 6c7b1c5 Compare March 19, 2026 18:08
@skjnldsv skjnldsv requested a review from susnux March 19, 2026 18:10
@skjnldsv skjnldsv force-pushed the fix/expand-theming-capabilities branch from 6c7b1c5 to ecfb95a Compare March 19, 2026 18:43
Comment thread apps/theming/lib/Service/JSDataService.php
Comment thread apps/theming/lib/Service/JSDataService.php
@skjnldsv skjnldsv requested a review from susnux March 19, 2026 21:11
@skjnldsv
Copy link
Copy Markdown
Member Author

Ah sorry, didn't see you already approved

@skjnldsv skjnldsv force-pushed the fix/expand-theming-capabilities branch 7 times, most recently from 7969d1e to 57fdce7 Compare March 24, 2026 13:12
@skjnldsv skjnldsv force-pushed the fix/expand-theming-capabilities branch from 57fdce7 to de953f1 Compare March 24, 2026 13:13
@skjnldsv
Copy link
Copy Markdown
Member Author

Sorry for the external team ping, rector was complaining so I ran it and it adjusted some dav php files 🙈

@skjnldsv skjnldsv force-pushed the fix/expand-theming-capabilities branch from de953f1 to c180632 Compare March 24, 2026 14:12
skjnldsv and others added 3 commits March 24, 2026 15:24
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit d677a3a into master Mar 24, 2026
205 of 209 checks passed
@skjnldsv skjnldsv deleted the fix/expand-theming-capabilities branch March 24, 2026 16:45
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants