Skip to content

fix: move download and enable button to outside of details tab#59465

Open
mykh-hailo wants to merge 1 commit intonextcloud:masterfrom
mykh-hailo:fix/app-download-and-enable-button-position
Open

fix: move download and enable button to outside of details tab#59465
mykh-hailo wants to merge 1 commit intonextcloud:masterfrom
mykh-hailo:fix/app-download-and-enable-button-position

Conversation

@mykh-hailo
Copy link
Copy Markdown
Contributor

@mykh-hailo mykh-hailo commented Apr 6, 2026

Summary

This change improves discoverability of app lifecycle actions in the App Store sidebar by moving install, update, remove, enable/disable, App API deploy options, and “delete data on remove” out of the Details tab and into the sidebar header description area, next to badges and the store rating.

The Details tab now focuses on group limits, dependencies, metadata, and links (interact section), while primary actions stay visible without switching tabs.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mykh-hailo mykh-hailo requested a review from a team as a code owner April 6, 2026 08:41
@mykh-hailo mykh-hailo requested review from nfebe, sorbaugh and szaimen and removed request for a team April 6, 2026 08:41
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 6, 2026

Can you please add screenshots?
How does this look on mobile?

@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 6, 2026
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@susnux Here are the screenshots before and update.

Screenshot for Wide Screens.

Before After
image image

Screenshot for narrow screens.

Before After
image image

P.S. We have the title and score and the button section is clipped on the left. To fix this issue, we have to fix NcAppSidebar component.

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from b77e55c to 6834740 Compare April 7, 2026 13:31
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@susnux I updated the code with the latest master branch.
I'd appreciate it if you check it please.

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 3 times, most recently from ad3aa25 to fb5dc2b Compare April 7, 2026 16:03
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@susnux , @skjnldsv
Can you possibly give me any feedback on this PR please?

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 2 times, most recently from b8c5ed1 to 6bbca83 Compare April 9, 2026 09:38
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@susnux , @skjnldsv , @szaimen , @nfebe , @sorbaugh
I'd appreciate it if you have time to review this PR.

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 6bbca83 to 5d71884 Compare April 9, 2026 14:36
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Comment thread apps/settings/src/components/AppStoreSidebar/AppStoreSidebarActions.vue Outdated
@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 5d71884 to 7dbb3fb Compare April 10, 2026 08:59
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 7dbb3fb to 51f2f6a Compare April 13, 2026 06:07
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mykh-hailo thanks a lot for the contribution!

I just tested this and there seems to be some problems with the limit apps to groups feature (it should be put onto a new line probably and not be positioned like a block element:

Grabacion.2026-04-13.163329.mp4

Additionally, there seems to be some problems with updating the internal state when using the enable, install or disable buttons so that always a full page reload is required to update the state:

Grabacion.2026-04-13.163527.mp4

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 51f2f6a to a5fcfdf Compare April 13, 2026 19:34
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@szaimen Thank you for your comments.
I updated the code base for that.
I'd appreciate it if you review it again.

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 3 times, most recently from 4de7f7a to 6fac68b Compare April 13, 2026 19:43
auto-merge was automatically disabled April 22, 2026 04:11

Head branch was pushed to by a user without write access

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 1b3a2cf to d9ea860 Compare April 22, 2026 04:11
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 22, 2026

@szaimen thank you for your comment.
I don't think it is related to mine.
The weird thing about the cypress is that sometimes they fail and sometime success.
I am not sure why it is.

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from d9ea860 to 431e14b Compare April 22, 2026 11:47
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@susnux , @szaimen I think we can merge this branch.
The cypress test failure is not related to my update.
My update is for the app sidebar but the test is for the app list.

@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@szaimen , @susnux please help me to merge this PR.
I don't think the cypress test is related to my updates.

@miaulalala
Copy link
Copy Markdown
Contributor

Hey @mykh-hailo - seems there's some conflicts and unrelated changes.

To fix it, can you:

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 2 times, most recently from 8d83180 to 7c0a8e6 Compare April 23, 2026 11:54
@artonge
Copy link
Copy Markdown
Collaborator

artonge commented Apr 23, 2026

@mykh-hailo the failing settings/apps.cy.ts e2e test seems really related.

@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@artonge can I update settings/apps.cy.ts?

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 2 times, most recently from 1fc897b to 90bac3a Compare April 23, 2026 15:24
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@artonge I updated the test for it.
could you review again please?

@mykh-hailo mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 90bac3a to b015947 Compare April 23, 2026 18:47
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@artonge , @szaimen , I updated the test for my update code but I am not sure if git actions use it.
Can you help me with that?

@szaimen
Copy link
Copy Markdown
Contributor

szaimen commented Apr 24, 2026

Hi @mykh-hailo I fear I cannot help you further on this. Probably best if you post your questions in https://cloud.nextcloud.com/call/xs25tz5y going forward. Thanks!

@mykh-hailo
Copy link
Copy Markdown
Contributor Author

Just one question @szaimen
I updated the cypress test for my update.
It will make this PR to pass the test successfully.

@mykh-hailo unfortinately the failing test seems to be related to your changes. Maybe the test needs to be adjusted?

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App management: The "download and enable" button should be moved outside the sidebar tab

6 participants