feat(ocp): expose whether talk is enabled for user#59918
feat(ocp): expose whether talk is enabled for user#59918
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
| * Check if Talk is disabled for the logged in user, respecting the | ||
| * per-group restriction configured in Talk admin settings | ||
| * (start_conversations). | ||
| * |
There was a problem hiding this comment.
| * Check if Talk is disabled for the logged in user, respecting the | |
| * per-group restriction configured in Talk admin settings | |
| * (start_conversations). | |
| * | |
| * Check if Talk is disabled for the logged in user. | |
| * |
The idea of the abstraction in OCP is to not reference Talk details iirc.
So should also not reference internal app configs 🙈
There was a problem hiding this comment.
Also, while I know the config in Talk is like this. I would name it positively, so have a isEnabledForUser
| * Check if the logged in user is not allowed to create conversations, | ||
| * respecting the per-group restrictions configured in Talk admin settings | ||
| * (allowed_groups). | ||
| * | ||
| * Returns false when Talk is not available at all. |
There was a problem hiding this comment.
Should be the same here positive phrase and method name:
| * Check if the logged in user is not allowed to create conversations, | |
| * respecting the per-group restrictions configured in Talk admin settings | |
| * (allowed_groups). | |
| * | |
| * Returns false when Talk is not available at all. | |
| * Check if the logged in user is allowed to create conversations. |
But while this is "trivial" at the moment, we have a pending request to allow "internal" conversations but block "public" conversations.
The question is whether we add a bool for public or the IConversationOptions as a parameter here.
But I guess from your calendar PR you don't know what kind of conversation the user is going to create? So maybe we keep it this way, and Talk returns true if a user is allowed to create any conversation here.
But creation call itself might still fail?
Summary
Expose the Talk app admin settings
start_conversationsandallowed_groupsthrough OCPChecklist
3. to review, feature component)stable32)AI (if applicable)