refactor: Cleanup application namespace handling#59977
Open
refactor: Cleanup application namespace handling#59977
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
changed the title
come-nc
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
come-nc
added
3. to review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
ChristophWurst
approved these changes
Apr 28, 2026
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Nice!
The two new methods look very testable 🫣
Comment on lines
+1179
to
+1180
| // If the tag is not found, fall back to uppercasing the first letter | ||
| $this->namespaceCache[$appId] = ucfirst($appId); |
Member
There was a problem hiding this comment.
Was wondering if that logic makes sense for app IDs with more than one word but this code just moved 👍
Comment on lines
+376
to
+389
|
|
||
| /** | ||
| * Get the app namespace | ||
| * | ||
| * @since 34.0.0 | ||
| */ | ||
| public function getAppNamespace(string $appId): string; | ||
|
|
||
| /** | ||
| * Get the app id for this namespace | ||
| * | ||
| * @since 34.0.0 | ||
| */ | ||
| public function getAppFromNamespace(string $className): ?string; |
Member
There was a problem hiding this comment.
new public API -> needs docs
ChristophWurst
added
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup application namespace handling.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)