Skip to content

Correct support of SI/IEC units for filesize#59978

Draft
Altahrim wants to merge 3 commits intomasterfrom
feat/utils-improvements
Draft

Correct support of SI/IEC units for filesize#59978
Altahrim wants to merge 3 commits intomasterfrom
feat/utils-improvements

Conversation

@Altahrim
Copy link
Copy Markdown
Collaborator

@Altahrim Altahrim commented Apr 28, 2026

Summary

Implements correct handling for SI/IEC units.
Add correct display for: #59965

TODO

  • Quota frontend display SI units but actually use 1024 base (it sends bytes so it's not an issue for backend)

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Altahrim Altahrim added this to the Nextcloud 34 milestone Apr 28, 2026
@Altahrim Altahrim self-assigned this Apr 28, 2026
@Altahrim Altahrim added 2. developing Work in progress php Pull requests that update Php code labels Apr 28, 2026
@Altahrim Altahrim force-pushed the feat/utils-improvements branch from 2dc0eee to 5c24eb9 Compare April 29, 2026 07:58
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the feat/utils-improvements branch 2 times, most recently from ff74835 to c6cbfda Compare April 29, 2026 09:00
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the feat/utils-improvements branch from c6cbfda to 969cc12 Compare April 29, 2026 13:03
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the frontend part, maybe that's a design decision, cc @marcoambrosini or @kra-mo.

Also cc @susnux as you worked on it IIRC.

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 29, 2026

For the frontend part

would need to be adjusted in the files library. But I think this is a great opportunity to finally localize it.
E.g. 1000.00 MB would be 1,000.00 MB in English, but 1.000,00 MB in German and 1 000,00 Mo in French.

see also #51623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants