Skip to content

test: Run tests against nextcloud/server#57760 share-update-check-single#16987

Closed
nickvergessen wants to merge 1 commit intomainfrom
test/server-57760/share-update-check-single
Closed

test: Run tests against nextcloud/server#57760 share-update-check-single#16987
nickvergessen wants to merge 1 commit intomainfrom
test/server-57760/share-update-check-single

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen commented Feb 5, 2026 •
edited
Loading

  • Root cause seems to be that for a share created in a new conversation, the other participants aren't registered as being in the room yet by the time the ShareCreatedEvent is emitted. So fetching the shares for the user doesn't return the share in the new room.
  • Active share validation/authoritative mount improvements server#57760 seems to fix it for the basic 1-1 room at least. Not sure if there are other edge cases

This was referenced Feb 6, 2026
Merged
Closed
@nickvergessen nickvergessen marked this pull request as draft February 7, 2026 20:19
@nickvergessen nickvergessen force-pushed the test/server-57760/share-update-check-single branch from fd2f7ea to 17d763a Compare February 27, 2026 06:34
@nickvergessen nickvergessen mentioned this pull request Feb 27, 2026
Merged
@nickvergessen nickvergessen added this to the 🏖️ Next Major (34) milestone Feb 28, 2026
@nickvergessen nickvergessen added bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings upstream labels Feb 28, 2026
@nickvergessen nickvergessen force-pushed the test/server-57760/share-update-check-single branch from 5f26dd1 to 2dbfdec Compare March 6, 2026 08:30
@nickvergessen nickvergessen mentioned this pull request Apr 10, 2026
Merged
@nickvergessen nickvergessen force-pushed the test/server-57760/share-update-check-single branch from 2dbfdec to 3c0f857 Compare April 24, 2026 19:34
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 24, 2026

Server PR was merged, dropping first commit and rebasing

@nickvergessen nickvergessen marked this pull request as ready for review April 24, 2026 19:34
@nickvergessen nickvergessen marked this pull request as draft April 24, 2026 20:16
@nickvergessen
test: Fix assumption that files are in Talk/ afterwards
974b1bc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the test/server-57760/share-update-check-single branch from 3c0f857 to 974b1bc Compare April 28, 2026 21:02
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 28, 2026

Seems no longer needed

@nickvergessen nickvergessen deleted the test/server-57760/share-update-check-single branch April 28, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

No one assigned

Labels

bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings tests upstream

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen @SystemKeeper