Skip to content

fix(ui): simplify signaling server error toast for non-admins#17322

Open
ShGKme wants to merge 1 commit intomainfrom
fix/app-name-5
Open

fix(ui): simplify signaling server error toast for non-admins#17322
ShGKme wants to merge 1 commit intomainfrom
fix/app-name-5

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Mar 9, 2026

☑️ Resolves

  • An end-user doesn't know that "signaling server" is
  • Keep the current message for admins only and simplify for the end user
  • In addition, make it branding-neutral for the end users

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Comment thread src/utils/signaling.js
Comment thread src/utils/signaling.js
)
if (getCurrentUser()?.isAdmin) {
showError(
t('spreed', 'The configured signaling server needs to be updated to be compatible with this version of Talk'),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing the string, i would even rewrite it to High-performance backend needs to be updated...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShGKme want to fix this?

Comment thread src/utils/signaling.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants