Skip to content

feat(conversationfolder): add frontend support for per-share conversa…#17549

Merged
DorraJaouad merged 1 commit intomainfrom
feat/4340/conversation-folder-frontend
Apr 24, 2026
Merged

feat(conversationfolder): add frontend support for per-share conversa…#17549
DorraJaouad merged 1 commit intomainfrom
feat/4340/conversation-folder-frontend

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Mar 30, 2026

…tion subfolders

Adds the API call layer and upload store integration to use the new POST /api/v1/chat/{token}/attachment endpoint when conversation subfolders are enabled.

AI-assisted-by: Claude Sonnet 4.6 noreply@anthropic.com

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@miaulalala miaulalala added this to the 🏖️ Next Major (34) milestone Mar 30, 2026
@miaulalala miaulalala requested a review from Antreesy March 30, 2026 10:21
@miaulalala miaulalala self-assigned this Mar 30, 2026
@miaulalala miaulalala removed their assignment Apr 8, 2026
@DorraJaouad DorraJaouad force-pushed the feat/4340/conversation-folder-frontend branch from c087eef to 290928a Compare April 13, 2026 10:06
@DorraJaouad DorraJaouad marked this pull request as ready for review April 13, 2026 10:06
@DorraJaouad DorraJaouad force-pushed the feat/4340/conversation-folder-frontend branch from 290928a to 204c095 Compare April 13, 2026 10:26
@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented Apr 17, 2026

Some backend questions:

  1. HPB failing to get the file, maybe because it's in draft fodler?
image
  1. Incoming shared folders (Bob > Alice) do not appear in file treed, as it's shared from files/Talk/Alice-token/Bob-bob to files/Talk/Bob-token/Bob-bob. What's the state on sharing support for 1-1 conversations?
    Asking because this bit is ignored for default share - and if Talk/ folder is missing, it will fail:

bb1a36d#diff-42169075c6c4b6aaa56b2023cc035b0e088ac7f76fd7d94ebd4b9e3af0d50a4eR60-R67

cc @miaulalala

Comment thread src/services/filesSharingServices.ts Outdated
Comment thread src/services/filesSharingServices.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/upload.ts Outdated
@DorraJaouad DorraJaouad force-pushed the feat/4340/conversation-folder-frontend branch from 848b67d to 4bd012e Compare April 20, 2026 10:14
@miaulalala

This comment was marked as resolved.

Comment thread src/types/index.ts Outdated
Comment thread src/services/filesSharingServices.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/services/filesSharingServices.ts Outdated
Comment thread src/services/__tests__/filesSharingServices.spec.js Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/upload.ts Outdated
Comment thread src/stores/__tests__/upload.spec.js Outdated
Comment thread src/stores/upload.ts Outdated
@DorraJaouad DorraJaouad force-pushed the feat/4340/conversation-folder-frontend branch from 4bd012e to 1b1b404 Compare April 23, 2026 11:05
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted lint, tests, and rename logic to work correctly. removed conditions for public/group, works with all conversations, as it's supposed to
Please rebase onto main, test once more and then squash fixups. Works nice! 🧑‍🍳🤌

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/4340/conversation-folder-frontend branch from d09b4af to 7465565 Compare April 24, 2026 07:48
@DorraJaouad DorraJaouad enabled auto-merge April 24, 2026 07:48
@DorraJaouad DorraJaouad merged commit 9313b60 into main Apr 24, 2026
52 checks passed
@DorraJaouad DorraJaouad deleted the feat/4340/conversation-folder-frontend branch April 24, 2026 07:49
@DorraJaouad DorraJaouad restored the feat/4340/conversation-folder-frontend branch April 24, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📂 Use subfolder for Talk attachments, one per conversation

3 participants