fix(noise-suppresion): allow auto-gain, rework UI#17672
fix(noise-suppresion): allow auto-gain, rework UI#17672
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
825107e to
8623282
Compare
b47c395 to
3bff8cc
Compare
Since we dont have High yet, only having Off Low Medium feels weird and wrong. |
|
How about then |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
3bff8cc to
b817d2e
Compare
|
Looks good in the screenshots! Could we just do a regular toggle for safari? Seems odd to do a Off/Advanced radio button when it's basically off/on |
We could, but I don't want to introduce a browser-specific difference in UI (which would be noticeable if Mac users are switching between browser and desktop client) |
And if the advanced+ option is rolled out we'd need to switch back. So 👍 to stick with the current approach If it's helpful we could show the "Basic" greyed out stating that it's not supported by Safari? |
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist