Skip to content

fix(noise-suppresion): allow auto-gain, rework UI#17672

Open
Antreesy wants to merge 4 commits intomainfrom
fix/noid/noise-levels-ui
Open

fix(noise-suppresion): allow auto-gain, rework UI#17672
Antreesy wants to merge 4 commits intomainfrom
fix/noid/noise-levels-ui

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Apr 9, 2026

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
2026-04-09_17h24_10 image
Safari image

🚧 Tasks

  • 'High' is not implemented and will be hidden until better times
  • Better wording for these labels?
  • Better Safari support (no 'Low', no auto gain constraint)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari ⚠️
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Apr 9, 2026
@Antreesy Antreesy requested a review from nimishavijay April 9, 2026 16:23
@Antreesy Antreesy self-assigned this Apr 9, 2026
@Antreesy Antreesy added design feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Apr 9, 2026
@nimishavijay

This comment was marked as resolved.

@Antreesy Antreesy force-pushed the fix/noid/noise-levels-ui branch from 825107e to 8623282 Compare April 10, 2026 14:33
@Antreesy Antreesy changed the title Fix/noid/noise levels UI fix(noise-suppresion): allow auto-gain, rework UI Apr 10, 2026
@Antreesy Antreesy force-pushed the fix/noid/noise-levels-ui branch from b47c395 to 3bff8cc Compare April 10, 2026 14:35
@Antreesy Antreesy marked this pull request as ready for review April 10, 2026 14:35
@nickvergessen
Copy link
Copy Markdown
Member

Reduce background noise for better voice quality.
Off Low Medium High

Since we dont have High yet, only having Off Low Medium feels weird and wrong.

@nimishavijay
Copy link
Copy Markdown
Member

nimishavijay commented Apr 13, 2026

How about then Off Basic Advanced ?

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/noise-levels-ui branch from 3bff8cc to b817d2e Compare April 13, 2026 09:22
@Antreesy Antreesy requested a review from DorraJaouad April 13, 2026 09:25
@nimishavijay
Copy link
Copy Markdown
Member

Looks good in the screenshots! Could we just do a regular toggle for safari? Seems odd to do a Off/Advanced radio button when it's basically off/on

@Antreesy
Copy link
Copy Markdown
Contributor Author

Could we just do a regular toggle for safari?

We could, but I don't want to introduce a browser-specific difference in UI (which would be noticeable if Mac users are switching between browser and desktop client)

@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 13, 2026

We could, but I don't want to introduce a browser-specific difference in UI (which would be noticeable if Mac users are switching between browser and desktop client)

And if the advanced+ option is rolled out we'd need to switch back. So 👍 to stick with the current approach

If it's helpful we could show the "Basic" greyed out stating that it's not supported by Safari?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants