Skip to content

fix(useGetParticipants): ensure user is in the room before checking permissions#17728

Merged
Antreesy merged 1 commit intomainfrom
fix/noid/ensure-in-room-for-signaling
Apr 23, 2026
Merged

fix(useGetParticipants): ensure user is in the room before checking permissions#17728
Antreesy merged 1 commit intomainfrom
fix/noid/ensure-in-room-for-signaling

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Patches a race condition UI <> signaling:
    • User leaves the call and conversation -> UI token already updated to new value (or '')
    • HPB sends the message with update.roomid = oldToken and update.users = [{ ...currentUser, callFlags: 0 }]
    • checkCurrentUserPermissions() -> conversation?... = undefined -> tries to fetch conversation with wrong token / no token

To test:

  • Join and leave voice room

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
See console ---

🚧 Tasks

  • FIXME - convert to issue? all _trigger() events currently passing only limited payload without token (although it's known)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Apr 15, 2026
@Antreesy Antreesy requested a review from DorraJaouad April 15, 2026 14:55
@Antreesy Antreesy self-assigned this Apr 15, 2026
@Antreesy Antreesy added bug feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Apr 15, 2026
…ermissions

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/ensure-in-room-for-signaling branch from dec3417 to ca68735 Compare April 22, 2026 14:04
@Antreesy
Copy link
Copy Markdown
Contributor Author

/backport to stable33

@Antreesy Antreesy merged commit a8dd271 into main Apr 23, 2026
53 checks passed
@Antreesy Antreesy deleted the fix/noid/ensure-in-room-for-signaling branch April 23, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants