refactor(room): Move getPropertiesForSignaling() to RoomPropertiesHelper#17772
Merged
nickvergessen merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
miaulalala
added
the
feature: api 🛠️
miaulalala
force-pushed
the
refactor/noid/move-getPropertiesForSignaling
branch
from
2c9fd61 to
bf102de
Compare
Extract Room::getPropertiesForSignaling() into a new Signaling\RoomPropertiesHelper service. This removes the IEventDispatcher constructor dependency from Room, continuing the preparatory cleanup towards migrating Room to extend OCP\AppFramework\Db\Entity. BackendNotifier and SignalingController now receive RoomPropertiesHelper via DI and delegate to it for building signaling properties. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
refactor/noid/move-getPropertiesForSignaling
branch
from
bf102de to
18bb1c8
Compare
nickvergessen
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Room::getPropertiesForSignaling() into a new Signaling\RoomPropertiesHelper service. This removes the IEventDispatcher constructor dependency from Room, continuing the preparatory cleanup towards migrating Room to extend OCP\AppFramework\Db\Entity.
BackendNotifier and SignalingController now receive RoomPropertiesHelper via DI and delegate to it for building signaling properties.
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
AI (if applicable)
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required