fix(App): wait to leave previous call before joining new one#17782
fix(App): wait to leave previous call before joining new one#17782
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
danxuliu
left a comment
There was a problem hiding this comment.
I have not tested it, but it makes sense 👍
If I am not mistaken (but I am speaking from memory, so take this with a pinch of salt) joining a new conversation implicitly leaves the old one, so a possible improvement might be to wait only if the user is active in a call, and otherwise just switch to the new conversation without waiting. This should solve the race condition when switching between calls and at the same time prevent the delays introduced with this fix when switching between conversations.
But as mentioned my assumption could be wrong and/or I could be missing other details, so fine by me to merge it as is even with the drawbacks and maybe improve it in a follow up.
|
/backport to stable33 |
|
/backport to stable32 |
☑️ Resolves
Example for switching rooms:
leaveConversationmight triggerleaveCall-> 'release webrtc media'joinConversationmight be followed byjoinCall-> 'start webrtc media'Drawbacks: longer visual switching.
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist