refactor(room): Remove Manager constructor dependency from Room#17790
Merged
nickvergessen merged 1 commit intomainfrom Apr 24, 2026
Merged
refactor(room): Remove Manager constructor dependency from Room#17790nickvergessen merged 1 commit intomainfrom
nickvergessen merged 1 commit intomainfrom
Conversation
miaulalala
added
feature: api 🛠️
Replace $this->manager in getDisplayName() with Server::get(Manager::class), matching the existing pattern used by getName() for ParticipantService. This removes the last injected service dependency from Room's constructor, leaving only ITimeFactory alongside the data fields. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
refactor/noid/remove-room-manager-dep
branch
from
114cf6b to
2a87840
Compare
nickvergessen
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace $this->manager in getDisplayName() with Server::get(Manager::class), matching the existing pattern used by getName() for ParticipantService. This removes the last injected service dependency from Room's constructor, leaving only ITimeFactory alongside the data fields.
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
AI (if applicable)
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required