refactor(room): Move one-to-one name resolution to RoomService#17791
Open
miaulalala wants to merge 1 commit intomainfrom
Open
refactor(room): Move one-to-one name resolution to RoomService#17791miaulalala wants to merge 1 commit intomainfrom
miaulalala wants to merge 1 commit intomainfrom
Conversation
Extract the lazy name reconstruction logic from Room::getName() into RoomService::resolveOneToOneName(). Room::getName() now delegates to it via Server::get(), keeping the same behaviour while moving the business logic to where it belongs. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added
enhancement
feature: api 🛠️
| $roomService->setName($this, json_encode($users), ''); | ||
| } | ||
| // TODO use DI | ||
| Server::get(RoomService::class)->resolveOneToOneName($this, $this->name); |
Member
There was a problem hiding this comment.
But now we already create the RoomService while before it was only needed if the name was not fixed already, which it was for everything that got ever rendered/created after Nextcloud 20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the lazy name reconstruction logic from Room::getName() into RoomService::resolveOneToOneName(). Room::getName() now delegates to it via Server::get(), keeping the same behaviour while moving the business logic to where it belongs.
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
AI (if applicable)
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required