Add further guidelines for implementation logic and code checks#2516
Merged
AndyScherzinger merged 1 commit intomainfrom Apr 24, 2026
Merged
Add further guidelines for implementation logic and code checks#2516AndyScherzinger merged 1 commit intomainfrom
AndyScherzinger merged 1 commit intomainfrom
Conversation
…e checks Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
blizzz
approved these changes
Apr 24, 2026
|
|
||
| ### Soft-invalidation ("broken" flag) | ||
|
|
||
| When a stored rule, filter, or condition references a column or option that no longer exists (due to deletion, type change, or import remapping), mark it `broken: true` instead of deleting it. Surface the broken state in the UI. Provide an auto-clear path that removes the flag when the rule is next saved in a valid state. |
Member
There was a problem hiding this comment.
not sure what this is, but okay.
Member
Author
There was a problem hiding this comment.
^ a peak into the future... 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added learnings from the recent PRs and discussions