Detect guest audio from MediaStream tracks instead of relying on Video/Data channel#6039
Detect guest audio from MediaStream tracks instead of relying on Video/Data channel#6039tareko wants to merge 1 commit intonextcloud:masterfrom
Conversation
…ing on DataChannel Guest users whose DataChannel never establishes would have isAudioEnabled stay false even though audio tracks exist in the MediaStream. This caused guests to appear as 'connecting' with no audio on mobile while working on desktop. - handleStreamChange() now sets isAudioEnabled based on audio track presence - handleIceConnectionStateChange() preserves audio/video state during ICE CHECKING/NEW if tracks are still present in the peer connection - Add enhanced diagnostic logging for guest participant debugging - Add GuestAudioDetectionTest documenting the expected behavior Signed-off-by: Tarek Loubani <tarek@tarek.org>
|
Hi @tareko |
|
Review is planned for this week |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Guest users whose DataChannel never establishes would have isAudioEnabled stay false even though audio tracks exist in the MediaStream. This caused guests to appear as 'connecting' with no audio on mobile while working on desktop.
This PR resolves issue #6037 . The debugging and code was done with the help of OpenCode using GLM-5.1 and Qwen-3.6 Plus.
🏁 Checklist
/backport to stable-xx.x