Hide filenames for media in chat.#6082
Conversation
|
I don't know how translations work for this app. Feel free to assign & resolve as needed. |
|
Translations happen via transifex, so for development it is is main strings.xml only. Anything else gets overwritten daily. Screenshots look nice. @nimishavijay for feedback especially regarding the config option, given we usually try to avoid them. |
|
My reason for adding a setting for it is that it can be useful for certain work scenarios. For example someone posting multiple versions of an image, with the version number in the filename. Yes, you can get it by clicking on the image, but it's sometimes truncated there. |
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice improvement @anakin78z !
As @AndyScherzinger mentioned, I would remove the setting as well and just hide the file names, as is done on other platforms.
For the truncation issue on multiple versions, we can solve it separately in the image viewer e.g. by middle ellipsizing the title.
|
+1 to avoid a setting for this.
Makes sense. Additionally we could also add a "info" item in the upper right corner menu of the image viewer to show the metadata (not in this PR). |
Signed-off-by: Jens Zalzala <jens@shakingearthdigital.com>
c429d0f to
c8135ef
Compare
|
I removed the setting & pushed the changes. |
mahibi
left a comment
There was a problem hiding this comment.
the behavior is not the same as on web (& other platforms).
As far as i see, for filetypes other than image and video, the filenames should always be shown.
For this, access to the mimetype would be necessary which is not the case in MediaMessage.kt.
But i would say it makes more sense to move the logic into getMediaContent in ChatMessageUi.kt so it's less logic in the UI.
Wdyt @anakin78z ?
|
Do other filetypes have previews? It only hides the filename if there is a preview. #6080 already passes the mimetype to MediaMessage, but for this usecase it could be done in ChatMessageUi.kt, or we could use |
Implements #6056
Added setting to always show filenames.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x