Skip to content

Hide filenames for media in chat.#6082

Open
anakin78z wants to merge 1 commit intonextcloud:masterfrom
anakin78z:6056-hide-media-filenames
Open

Hide filenames for media in chat.#6082
anakin78z wants to merge 1 commit intonextcloud:masterfrom
anakin78z:6056-hide-media-filenames

Conversation

@anakin78z
Copy link
Copy Markdown
Contributor

Implements #6056

Added setting to always show filenames.

🖼️ Screenshots

🏚️ Before 🏡 After ⚙️ Setting
Screenshot_20260415_142108 Screenshot_20260415_142035 Screenshot_20260415_143559

🚧 TODO

  • Translate setting text, @string/nc_settings_show_media_filenames_title & @string/nc_settings_show_media_filenames_desc

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@anakin78z anakin78z marked this pull request as ready for review April 15, 2026 19:42
@anakin78z
Copy link
Copy Markdown
Contributor Author

I don't know how translations work for this app. Feel free to assign & resolve as needed.

@AndyScherzinger
Copy link
Copy Markdown
Member

Translations happen via transifex, so for development it is is main strings.xml only. Anything else gets overwritten daily.

Screenshots look nice. @nimishavijay for feedback especially regarding the config option, given we usually try to avoid them.

@AndyScherzinger AndyScherzinger added enhancement New feature or request design Related to the design 3. to review Waiting for reviews labels Apr 15, 2026
@anakin78z
Copy link
Copy Markdown
Contributor Author

My reason for adding a setting for it is that it can be useful for certain work scenarios. For example someone posting multiple versions of an image, with the version number in the filename. Yes, you can get it by clicking on the image, but it's sometimes truncated there.

Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement @anakin78z !

As @AndyScherzinger mentioned, I would remove the setting as well and just hide the file names, as is done on other platforms.

For the truncation issue on multiple versions, we can solve it separately in the image viewer e.g. by middle ellipsizing the title.

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Apr 20, 2026

+1 to avoid a setting for this.

For the truncation issue on multiple versions, we can solve it separately in the image viewer e.g. by middle ellipsizing the title.

Makes sense. Additionally we could also add a "info" item in the upper right corner menu of the image viewer to show the metadata (not in this PR).

Signed-off-by: Jens Zalzala <jens@shakingearthdigital.com>
@anakin78z anakin78z force-pushed the 6056-hide-media-filenames branch from c429d0f to c8135ef Compare April 20, 2026 12:12
@anakin78z
Copy link
Copy Markdown
Contributor Author

I removed the setting & pushed the changes.

@anakin78z anakin78z requested a review from jancborchardt April 21, 2026 18:14
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the behavior is not the same as on web (& other platforms).

As far as i see, for filetypes other than image and video, the filenames should always be shown.
For this, access to the mimetype would be necessary which is not the case in MediaMessage.kt.

But i would say it makes more sense to move the logic into getMediaContent in ChatMessageUi.kt so it's less logic in the UI.
Wdyt @anakin78z ?

@anakin78z
Copy link
Copy Markdown
Contributor Author

Do other filetypes have previews? It only hides the filename if there is a preview.

#6080 already passes the mimetype to MediaMessage, but for this usecase it could be done in ChatMessageUi.kt, or we could use remember in the MediaMessage.

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design enhancement New feature or request

Projects

Status: 🏗️ At engineering

Development

Successfully merging this pull request may close these issues.

4 participants