Backport/6079/improve answering calls

[mahibi]

manual backport of #6015
replacing #6079

🖼️ Screenshots

🏚️ Before	🏡 After
B	A

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[Copilot]

Pull request overview

Backport of Talk Android changes to improve the incoming-call experience (notification actions, ringing behavior after answering, and lock-screen behavior), aligning stable branch behavior with PR #6015.

Changes:

• Add NotificationCompat.CallStyle incoming-call notification with answer/decline actions and caller avatar support.
• Cancel the ringing notification when an incoming call is answered, and adjust lock-screen/keyguard handling.
• Register a new DeclineCallReceiver and update Gradle verification metadata.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
gradle/verification-metadata.xml	Updates dependency verification metadata entries (sha entries / also-trust).
app/src/main/java/com/nextcloud/talk/receivers/DeclineCallReceiver.kt	Adds receiver used by the notification “Decline” action to cancel the call notification.
app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt	Builds improved incoming call notifications (CallStyle), adds answer/decline PendingIntents, adjusts threading.
app/src/main/java/com/nextcloud/talk/activities/CallBaseActivity.java	Changes keyguard/lock-screen behavior when showing call UI.
app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt	Cancels incoming-call notification after answering; adjusts initial camera enabling behavior.
app/src/main/AndroidManifest.xml	Registers DeclineCallReceiver.

Comments suppressed due to low confidence (1)

app/src/main/java/com/nextcloud/talk/activities/CallBaseActivity.java:82

• dismissKeyguard() no longer dismisses the keyguard (it only sets show-when-locked/turn-screen-on flags). This makes the method name misleading and also leaves enableKeyguard() clearing FLAG_DISMISS_KEYGUARD even though it's no longer set anywhere in this flow. Consider renaming the method (or updating documentation) and keeping the enable/disable flag handling consistent.

    void dismissKeyguard() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O_MR1) {
            setShowWhenLocked(true);
            setTurnScreenOn(true);
        } else {
            getWindow().addFlags(WindowManager.LayoutParams.FLAG_SHOW_WHEN_LOCKED);
            getWindow().addFlags(WindowManager.LayoutParams.FLAG_TURN_SCREEN_ON);
        }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/6085.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	88	98
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	53	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	80	81

SpotBugs increased!

[sowjanyakch]

when I start a voice call from web, I get call notification on android and I click on video call from the notification itself and I join the call without video enabled. When I start a video call from web, I receive a call notification, I click on video call from the call notification itself, I join the call with video enabled.

The button Video call might be confusing here. We can rename it to something more generic like Join a call.

[mahibi]

when I start a voice call from web, I get call notification on android and I click on video call from the notification itself and I join the call without video enabled. When I start a video call from web, I receive a call notification, I click on video call from the call notification itself, I join the call with video enabled.

Disabling the video was the outcome of the poll in the team meeting. Also see #6015 (comment)

The button Video call might be confusing here. We can rename it to something more generic like Join a call.

Same behavior as for other messengers, so should be fine