fix(tts): wire dashboard tts.timeout_ms through ApplySystemConfigs + seed#1176
Merged
mrgoonie merged 1 commit intoJun 15, 2026
Merged
Conversation
…seed ApplySystemConfigs and seedConfigForContext both handle tts.provider, tts.auto, tts.mode, tts.max_length — but neither carries tts.timeout_ms. Result: the dashboard /tts page Timeout (ms) input is inert; cfg.Tts.TimeoutMs stays at config.json default; setupTTS passes 0 to provider constructors; each provider falls back to its hardcoded default (e.g. edge = 30s). Two-line fix to mirror the existing pattern for the other tts.* keys.
Contributor
Contributor
|
review-pr --fix --reply result Verdict: Approve. Summary: This PR wires Iterations: 1 review/verify loop, 0 fix commits. Local verification run:
Unresolved blockers/questions: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
`ApplySystemConfigs` and `seedConfigForContext` both handle `tts.provider`, `tts.auto`, `tts.mode`, `tts.max_length` — but neither carries `tts.timeout_ms`. Result: the dashboard /tts page Timeout (ms) input is inert; `cfg.Tts.TimeoutMs` stays at config.json default; `setupTTS` passes 0 to provider constructors; each provider falls back to its hardcoded default (Edge = 30s).
Real-world impact
Tenant configures Timeout=300000 (5 min) on the dashboard for long-form TTS. Saves. Trace still shows `tts failed: edge-tts failed: signal: killed` at exactly 30s. The dashboard value never reached the provider.
Fix
Two-line addition mirroring the existing pattern for the other `tts.*` keys:
Hot-reload (`tts-config-reload` subscriber in lifecycle) re-builds the manager + Edge provider, so the dashboard change now propagates without restart.
Test plan