feat(cron): create command payloads in UI#1288
Merged
clark-cant merged 1 commit intoJun 27, 2026
Merged
Conversation
clark-cant
approved these changes
Jun 27, 2026
clark-cant
left a comment
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
LGTM — clean follow-up to #1287. Payload type toggle, Zod cross-field validation, and i18n all look correct. Approving; will merge once go CI goes green.
Posted by /ck:review-pr at 2026-06-27T05:23:30Z
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1279, #1285, #1286, and #1287. Command cron jobs can now run, show up in the dashboard, and be edited; this PR adds command payload creation support to the cron create dialog.
The create surface stays intentionally JSON-based to match the existing edit flow: users choose Agent vs Command payload, command creation validates that
argvis a non-empty array, and submits the existingCronCommandSpecshape tocron.create.Type
main)Target Branch
Targets
dev.Checklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan
corepack prepare pnpm@10.30.1 --activate && pnpm --dir ui/web buildenv -u GOCLAW_CONFIG -u GOCLAW_DATA_DIR -u GOCLAW_HOST -u GOCLAW_PORT -u GOCLAW_PUBLIC_URL -u GOCLAW_ALLOWED_ORIGINS PATH=/usr/local/go/bin:$PATH go build ./...env -u GOCLAW_CONFIG -u GOCLAW_DATA_DIR -u GOCLAW_HOST -u GOCLAW_PORT -u GOCLAW_PUBLIC_URL -u GOCLAW_ALLOWED_ORIGINS PATH=/usr/local/go/bin:$PATH go build -tags sqliteonly ./...