fix: preflight compact v3 context before model calls#1297
Merged
clark-cant merged 1 commit intoJun 28, 2026
Merged
Conversation
Run pruning before ThinkStage so oversized histories compact before the provider request is built. Persist V3 last_prompt_tokens with the post-flush persisted message count so post-run compaction calibration has current usage data. Tests: go test ./internal/pipeline -run "TestNewDefaultPipeline_PrunesBeforeThink|TestFinalizeStage_UpdateMetadataReceivesPersistedMessageCount" -count=1; go test ./internal/agent -run "^$" -count=1
clark-cant
approved these changes
Jun 28, 2026
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
Clean, focused fix. Pipeline reorder (Prune before Think) is correct — over-budget histories should be compacted before provider calls. UpdateMetadata msgCount addition matches V2 calibration behavior. Good regression coverage.
Verdict: Approve
- Duplicate/prior work: clear — no prior implementation of preflight V3 compaction
- Project standards: compliant
- Strategic necessity: clear value — fixes context budget calibration for V3 pipeline
- Risk: Low — 6 files, +123/-8, well-tested
Posted by github-maintain at $(date -u +%Y-%m-%dT%H:%M:%SZ)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Surface parity