feat: add GitHub Copilot CLI platform support#277
Open
JiaqiZhang-Dev wants to merge 4 commits into
Open
Conversation
Add 'copilot-cli' as a new platform type for the GitHub Copilot coding agent. This installs the skill to .github/skills/ui-ux-pro-max/ (separate from VS Code Copilot's .github/prompts/ path). Changes: - New platform config copilot-cli.json (src + cli assets) - Add copilot-cli to AIType, AI_TYPES, AI_FOLDERS - Add detection via .github/copilot-instructions.md - Add AI_TO_PLATFORM mapping - Update README with new platform Agent-Logs-Url: https://github.com/JiaqiZhang-Dev/ui-ux-pro-max-skill/sessions/837ef0ab-1be3-4164-b4d9-0d7b3b3d8fd8 Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JiaqiZhang-Dev/ui-ux-pro-max-skill/sessions/160bd651-8a50-437d-9968-71fdac04cb79 Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
…port feat: add GitHub Copilot CLI platform support
mrgoonie
requested changes
Jun 22, 2026
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: Copilot CLI support is a useful platform addition and the PR updates both canonical src/ templates and packaged CLI assets, but the proposed install path is not aligned with GitHub Copilot custom instruction conventions and will likely not be auto-loaded by Copilot.
Risk level: Medium
Mandatory gates:
- Duplicate/prior implementation: overlap checked — #328 covers VS Code Copilot prompt-file behavior, but no existing Copilot CLI platform PR implements this
copilot-clitarget. - Project standards: issue found — source and CLI asset copies are both added, but platform detection/install semantics need to match the target assistant.
- Strategic necessity: clear value — first-class Copilot CLI support would reduce manual install friction for GitHub Copilot users.
- CI/checks: locally blocked — this environment has no
bun, sonpm --prefix cli run buildcannot complete; the screenshot only proves a skill-like command is loaded, not that GitHub Copilot CLI will consume.github/skills.
Findings:
- Important: The new platform installs
SKILL.mdunder.github/skills/ui-ux-pro-max/, but the detection logic keys off.github/copilot-instructions.md, and the repository's existing Copilot support uses.github/prompts/. I don't see evidence in the PR that GitHub Copilot CLI auto-loads arbitrary.github/skills/*/SKILL.mddirectories. Please verify the documented Copilot CLI/custom-instructions location and adjust the platform config accordingly, or include a link/test showing.github/skills/ui-ux-pro-max/SKILL.mdis actually discovered by Copilot CLI. - Important:
detectAIType()will detect bothcopilotandcopilot-cliwhenever.github/copilot-instructions.mdexists, because it first pushescopilotfor any.githubdirectory and then pushescopilot-cli. That makes the suggested type becomeall, so a Copilot CLI project can get all-platform install behavior instead of the specificcopilot-clitarget. Please make the detection precedence unambiguous.
Verdict: REQUEST_CHANGES
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill supports GitHub Copilot in VS Code (
.github/prompts/) but not the GitHub Copilot CLI. This addscopilot-clias a new platform type, installing to.github/skills/ui-ux-pro-max/.Changes
copilot-cli.jsonin bothsrc/ui-ux-pro-max/templates/platforms/andcli/assets/templates/platforms/cli/src/types/index.ts): Addedcopilot-clitoAIType,AI_TYPES, andAI_FOLDERS(maps to['.github'])cli/src/utils/detect.ts): Auto-detects via.github/copilot-instructions.mdcli/src/utils/template.ts): AddedAI_TO_PLATFORMentryuipro init --ai copilot-cli # GitHub Copilot CLITests